Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and fix issues with find #325

Open
5 tasks
shcheklein opened this issue Dec 27, 2023 · 0 comments
Open
5 tasks

Review and fix issues with find #325

shcheklein opened this issue Dec 27, 2023 · 0 comments
Labels
bug Something isn't working fs fsspec implementation priority-p1

Comments

@shcheklein
Copy link
Member 

          okay, problems that I see:
  • maxdepth is not supported
  • withdirs is not supported (must have for expand path)
  • doesn't check bucket name find('.') and find('etasderwer') return the same result
  • it keeps appending ids to cache every time even for already known
  • cache is not locked (multithreading support) - this is a bit more advanced and less critical to start with

Originally posted by @shcheklein in #229 (comment)
@shcheklein shcheklein added bug Something isn't working fs fsspec implementation priority-p1 labels Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fs fsspec implementation priority-p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shcheklein