Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner/github: increase self-hosted timeout to 35days #1064

Closed
3 tasks
casperdcl opened this issue Jun 16, 2022 · 1 comment · Fixed by #1067
Closed
3 tasks

runner/github: increase self-hosted timeout to 35days #1064

casperdcl opened this issue Jun 16, 2022 · 1 comment · Fixed by #1067
Assignees
Labels
ci-github cml-runner Subcommand enhancement New feature or request

Comments

@casperdcl
Copy link
Contributor

casperdcl commented Jun 16, 2022

https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners#usage-limits now shows 35d (not 72h).

(original thread #1054 (comment))

@danieljimeneznz
Copy link
Contributor

danieljimeneznz commented Jun 18, 2022

I have opened a PR for this change (referenced above) - I also question whether or not the change is actually necessary based on the Github documentation - https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes

I guess it is a good backup to ensure the runner is always shutdown after a predetermined amount of time, maybe we do 35 days + 5 minutes instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-github cml-runner Subcommand enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants