Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner: --idle-timeout not passed to terraform #877

Closed
casperdcl opened this issue Jan 20, 2022 · 4 comments · Fixed by #878
Closed

runner: --idle-timeout not passed to terraform #877

casperdcl opened this issue Jan 20, 2022 · 4 comments · Fixed by #878
Assignees
Labels
bug Something isn't working p0-critical Max priority (ASAP)

Comments

@casperdcl
Copy link
Contributor

cml runner --idle-timeout=-1 ...
info: Terraform apply...
info: {..., "idleTimeout":300, ...}

happens on e.g. --cloud=gcp and --cloud=aws but does not happen on-prem (local) where terraform isn't used

@0x2b3bfa0

This comment has been minimized.

@0x2b3bfa0 0x2b3bfa0 transferred this issue from another repository Jan 20, 2022
@0x2b3bfa0 0x2b3bfa0 transferred this issue from iterative/terraform-provider-iterative Jan 20, 2022
@0x2b3bfa0 0x2b3bfa0 self-assigned this Jan 21, 2022
@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working p0-critical Max priority (ASAP) labels Jan 21, 2022
@DavidGOrtega
Copy link
Contributor

I remember this hitting me testing a few weeks ago, however I finally determined it was correct... or almost. Happens that -1 is not accepted in cloud instances

${
    typeof idleTimeout !== 'undefined' && idleTimeout >= 0
      ? `idle_timeout = ${idleTimeout}`
      : ''
  }

Where you trying -1 @casperdcl ?

@casperdcl
Copy link
Contributor Author

Not sure I follow the question. cml runner --idle-timeout=-1 --cloud=aws results in idle_timeout = 300 being passed to terraform.

bin/cml/runner.js::runLocal is fine.

bin/cml/runner.js::runCloud has a bug.

@0x2b3bfa0
Copy link
Member

Nota bene: -1 is accepted everywhere since #700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p0-critical Max priority (ASAP)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants