Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy file signals in DataChain.from_storage() #32

Closed
Tracked by #33
rlamy opened this issue Jul 5, 2024 · 2 comments · Fixed by #72
Closed
Tracked by #33

Remove legacy file signals in DataChain.from_storage() #32

rlamy opened this issue Jul 5, 2024 · 2 comments · Fixed by #72
Assignees
@rlamy

Comments

@rlamy
Copy link
Contributor

rlamy commented Jul 5, 2024 •
edited
Loading

Include .except("source", "parent", "name", ...) in .from_storage(). So, user won't see the legacy signals anymore.

Note: after iterative/dvcx#1695, that still runs into issues with the "id" column.
@dmpetrov dmpetrov mentioned this issue Jul 13, 2024
Closed
@dmpetrov dmpetrov transferred this issue from another repository Jul 13, 2024
@rlamy
Copy link
Contributor Author

rlamy commented Jul 16, 2024

I think this is blocked on #28.

@rlamy rlamy mentioned this issue Jul 17, 2024
Merged
@shcheklein
Copy link
Member

@rlamy assigned you (just for visibility for everyone). Please feel free to un-assign if it was wrong.

@rlamy rlamy closed this as completed in #72 Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlamy rlamy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove legacy signals in from_storage() iterative/datachain
2 participants
@rlamy @shcheklein