Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Pydantic classes be natively supported without Feature #43

Closed
dmpetrov opened this issue Jul 13, 2024 · 1 comment
Closed

Can Pydantic classes be natively supported without Feature #43

dmpetrov opened this issue Jul 13, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@dmpetrov
Copy link
Member

dmpetrov commented Jul 13, 2024

Description

Feature use to have a good amount of logic in it. Especially related to SQL transpilation:

  • _delimiter='__' which become global variable DEFAULT_DELIMITER
  • _shallow=False which is not supported now.

Now the transpilation was unified. Only small number of params left:

  • _is_file
  • _version

It feels like we can get rid of Feature class as well as pydantic_to_feature() that causes multiple issues with multi-processing/threading. We just need to implement all the Feature logic as decorator class (not python-decorator @) instead of parent class. This idea was was briefly discussed in iterative/dvcx#1625

In that way, pydantic's BaseModel would become a feature class.

@dmpetrov dmpetrov added enhancement New feature or request question Further information is requested labels Jul 13, 2024
@dmpetrov dmpetrov self-assigned this Jul 13, 2024
@dmpetrov dmpetrov mentioned this issue Jul 14, 2024
3 tasks
@dmpetrov
Copy link
Member Author

Closed by #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant