Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: add --out for local targets #2220

Closed
jorgeorpinel opened this issue Feb 19, 2021 · 5 comments · Fixed by #2246
Closed

ref: add --out for local targets #2220

jorgeorpinel opened this issue Feb 19, 2021 · 5 comments · Fixed by #2246
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference 🐛 type: bug Something isn't working.

Comments

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Feb 19, 2021

UPDATE: I see this is actually possible now (2.0). We should document it!
Q: Does the same apply to import-url?


Currently add -o only applies to "transferred" (external) data — straight-to-cache/remote functionality.

Since we're allowing add to move target data paths now, why not enable it for targets in the workspace too? E.g.:

$ ls
yowassup
$ dvc add ./yowassup -o nicername
...
$ ls
yowassup  nicername  nicername.dvc

Other than UI consistency, there could be actual use cases for this like tracking copies of a same dataset that you know will have variations in different stages/pipelines (may work well with foreach stages).

+ I assume enabling this at this point is as easy as removing the restriction that prevents it.

@jorgeorpinel

This comment has been minimized.

@jorgeorpinel jorgeorpinel transferred this issue from iterative/dvc Feb 19, 2021
@jorgeorpinel jorgeorpinel changed the title add: allow --out for local targets? ref: doc add --out for local targets Feb 19, 2021
@jorgeorpinel jorgeorpinel added 🐛 type: bug Something isn't working. A: docs Area: user documentation (gatsby-theme-iterative) labels Feb 19, 2021
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Feb 19, 2021

Docs should also clarify that -o by itself implies "skip workspace" (straight-to-cache) for external targets. But creates the "copy" (link usually) for local ones.

@jorgeorpinel
Copy link
Contributor Author

Hi @isidentical. Could you maybe point to the PR where this was introduced? Not critical but could be helpful. Thanks

@jorgeorpinel jorgeorpinel changed the title ref: doc add --out for local targets ref: add/import? --out for local targets Feb 19, 2021
@jorgeorpinel jorgeorpinel changed the title ref: add/import? --out for local targets ref: add --out for local targets Feb 19, 2021
@isidentical
Copy link
Contributor

isidentical commented Feb 19, 2021

Since we're allowing add to move target data paths now, why not enable it for targets in the workspace too

It is already supported.

point to the PR where this was introduced

iterative/dvc/pull/5301

@jorgeorpinel
Copy link
Contributor Author

already supported

Yep thanks @isidentical that's why I had already moved this to the docs repo 🙂

Thanks for the core PR link!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference 🐛 type: bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants