-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
params: clarify when they're granular #4202
Comments
Specific places where this issue exists now:
|
For dependencies, they are granular. Top-level params are not dependencies of any stage. We can further clarify, but I'm not sure I see anything inaccurate here. |
The problem I see is in the context because we now have these "top-level params" that are not really parameters in the way we've defined them before (granular dependencies) but they're called the same. Maybe each page is consistent internally but not vs. each other. In fact this causes internal inconsistencies e.g. rn https://dvc.org/doc/user-guide/project-structure/dvcyaml-files#params has a tooltip (param dep text) in a possible context for top-level params: |
What's the purpose of top-level param definitions? Couldn't find much context from quickly skimming thgough iterative/dvc#8529 and #4180. And I guess they all share a file-type definition (JSON/YAML/TOML key-pair files) so perhaps we can address via #2572 (comment) or even make a new reference section called File Formats (along with the CLI and APR refs). |
The only issue is that we currently tend to explain parameters as a "granular kind of dependency". So we should review these existing, older texts out there or find some other distinction like calling top-level params "general param files", or something else.
Originally posted by @jorgeorpinel in #4180 (comment)
See full #4180 (review) for other suggestions.
Related to #2412 ?
The text was updated successfully, but these errors were encountered: