Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params: clarify when they're granular #4202

Closed
jorgeorpinel opened this issue Dec 22, 2022 · 4 comments
Closed

params: clarify when they're granular #4202

jorgeorpinel opened this issue Dec 22, 2022 · 4 comments
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference

Comments

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Dec 22, 2022

Given that params defined at the top-level do not support granularity.

The only issue is that we currently tend to explain parameters as a "granular kind of dependency". So we should review these existing, older texts out there or find some other distinction like calling top-level params "general param files", or something else.

Originally posted by @jorgeorpinel in #4180 (comment)

See full #4180 (review) for other suggestions.


Related to #2412 ?

@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide labels Dec 22, 2022
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Dec 22, 2022

Specific places where this issue exists now:

Cc @skshetry @dberenbaum

@jorgeorpinel jorgeorpinel added the 🐛 type: bug Something isn't working. label Dec 22, 2022
@dberenbaum
Copy link
Contributor

For dependencies, they are granular. Top-level params are not dependencies of any stage. We can further clarify, but I'm not sure I see anything inaccurate here.

@jorgeorpinel jorgeorpinel removed the 🐛 type: bug Something isn't working. label Dec 23, 2022
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Dec 23, 2022

I'm not sure I see anything inaccurate

The problem I see is in the context because we now have these "top-level params" that are not really parameters in the way we've defined them before (granular dependencies) but they're called the same. Maybe each page is consistent internally but not vs. each other.

In fact this causes internal inconsistencies e.g. rn https://dvc.org/doc/user-guide/project-structure/dvcyaml-files#params has a tooltip (param dep text) in a possible context for top-level params:

image

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Dec 23, 2022

What's the purpose of top-level param definitions? Couldn't find much context from quickly skimming thgough iterative/dvc#8529 and #4180.

And I guess they all share a file-type definition (JSON/YAML/TOML key-pair files) so perhaps we can address via #2572 (comment) or even make a new reference section called File Formats (along with the CLI and APR refs).

@jorgeorpinel jorgeorpinel added the C: ref Content of /doc/*-reference label Dec 23, 2022
@dberenbaum dberenbaum closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference
Projects
None yet
Development

No branches or pull requests

2 participants