Skip to content

Conversation

@shcheklein
Copy link
Contributor

Fixes #922

Disregard the recommendations below if you use Edit on GitHub button to improve the docs in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This enables GitHub to link the PR to the corresponding bug and close it automatically when PR is merged.

Thank you for the contribution - we'll try to review and merge it as soon as possible. 🙏

@shcheklein shcheklein temporarily deployed to dvc-landing-fix-922-obppbqzgel January 17, 2020 07:07 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-fix-922-obppbqzgel January 18, 2020 17:56 Inactive
@shcheklein shcheklein merged commit cc30c4a into master Jan 20, 2020
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry didn't get to review this earlier. Code looks good but I did a sanity check and it seems that the md text to render should remove the {#hash} part of the title:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

md: enable custom anchor id/href for troubleshooting guide?

3 participants