Skip to content

Conversation

@Criztov
Copy link
Contributor

@Criztov Criztov commented Jan 21, 2020

change target stage from default (Dvcfile) to evaluate.dvc due to repository change in example

Disregard the recommendations below if you use Edit on GitHub button to improve the docs in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This enables GitHub to link the PR to the corresponding bug and close it automatically when PR is merged.

Thank you for the contribution - we'll try to review and merge it as soon as possible. 🙏

change target stage from default (Dvcfile) to evaluate.dvc due to repository change in example
@pared
Copy link
Contributor

pared commented Jan 21, 2020

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate it!

@jorgeorpinel jorgeorpinel merged commit 2603116 into treeverse:master Jan 21, 2020
@shcheklein
Copy link
Contributor

@Criztov @jorgeorpinel @pared this is a wrong change. so called "Deep Tutorial" is not using the example_get_started project. It has different set of commands, different structure. And if you follow it as it is now you should be able to run dvc repro since it supposed to have a Dvcfile (a default target).

@jorgeorpinel
Copy link
Contributor

I see. Sorry, should've looked at the context... Please approve/merge #940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants