Merge pull request #3027 from Suor/status-noop

ui: warn about ignored options for `dvc status` and a grammar fix

Author: efiop

dvc/exceptions.py

@@ -167,7 +167,7 @@ def __init__(self, dvc_file_name):
 class BadMetricError(DvcException):
     def __init__(self, paths):
         super().__init__(
-            "the following metrics do not exists, "
+            "the following metrics do not exist, "
             "are not metric files or are malformed: {paths}".format(
                 paths=", ".join("'{}'".format(path) for path in paths)
             )

dvc/repo/status.py

@@ -1,7 +1,9 @@
 import logging
+from itertools import compress
 
 from funcy.py3 import cat
 
+from dvc.exceptions import DvcException
 from . import locked
 
 
@@ -113,4 +115,15 @@ def status(
             remote=remote,
             all_tags=all_tags,
         )
+
+    ignored = list(
+        compress(
+            ["--all-branches", "--all-tags", "--jobs"],
+            [all_branches, all_tags, jobs],
+        )
+    )
+    if ignored:
+        msg = "the following options are meaningless for local status: {}"
+        raise DvcException(msg.format(", ".join(ignored)))
+
     return _local_status(self, targets, with_deps=with_deps)

tests/func/test_metrics.py

@@ -868,6 +868,6 @@ def test_show_multiple_outputs(tmp_dir, dvc, caplog):
         assert 1 == main(["metrics", "show", "1.json", "not-found"])
         assert '1.json: {"AUC": 1}' in caplog.text
         assert (
-            "the following metrics do not exists, "
+            "the following metrics do not exist, "
             "are not metric files or are malformed: 'not-found'"
         ) in caplog.text