Skip to content

Commit 710c4bd

Browse files
committed
s3: test: mocker instead of mock annotations
1 parent c167eb2 commit 710c4bd

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

tests/unit/remote/test_s3.py

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
import pytest
1+
import logging
22

3-
from dvc.config import ConfigError
4-
from dvc.remote.s3 import RemoteS3
3+
import pytest
4+
from mock import patch
5+
from dvc.remote import RemoteS3
56
from tests.utils import empty_caplog
67

78
bucket_name = "bucket-name"
@@ -59,22 +60,23 @@ def test_grants_mutually_exclusive_acl_error(grants):
5960
@pytest.mark.parametrize(
6061
"default_jobs_number,expected_result", [(10, 10), (13, 12)]
6162
)
62-
@patch("resource.getrlimit", return_value=(256, 1024))
6363
def test_adjust_default_jobs_number(
64-
_, caplog, default_jobs_number, expected_result
64+
mocker, caplog, default_jobs_number, expected_result
6565
):
6666
remote = RemoteS3(None, {})
6767

68-
with empty_caplog(caplog), patch.object(
69-
remote, "JOBS", default_jobs_number
70-
):
68+
mocker.patch("resource.getrlimit", return_value=(256, 1024))
69+
mocker.patch.object(remote, "JOBS", default_jobs_number)
70+
71+
with empty_caplog(caplog):
7172
assert remote.adjust_jobs() == expected_result
7273

7374

74-
@patch("resource.getrlimit", return_value=(256, 1024))
75-
def test_warn_on_too_many_jobs(_, caplog):
75+
def test_warn_on_too_many_jobs(mocker, caplog):
7676
remote = RemoteS3(None, {})
7777

78+
mocker.patch("resource.getrlimit", return_value=(256, 1024))
79+
7880
with caplog.at_level(logging.INFO, "dvc"):
7981
assert remote.adjust_jobs(64) == 64
8082
assert len(caplog.messages) == 1

0 commit comments

Comments
 (0)