Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote default with no argument removes default #2813

Closed
kaiogu opened this issue Nov 19, 2019 · 3 comments · Fixed by #2821
Closed

remote default with no argument removes default #2813

kaiogu opened this issue Nov 19, 2019 · 3 comments · Fixed by #2821
Assignees
Labels
bug Did we break something? p1-important Important, aka current backlog of things to do

Comments

@kaiogu
Copy link
Contributor

kaiogu commented Nov 19, 2019

Running dvc remote default with no argument sets default remote to None.
According to documentation this should show the default remote though.

Setting default remote:

>>dvc remote default my_remote
>>git diff
... 
+[core]
+remote = my_remote
...

This should query the default, but sets default to None:

>>dvc remote default
>>git diff
...
+[core]
+remote = None

DVC version: 0.66.11
OS: Ubuntu 18.04.2 LTS
Method: From repository

@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Nov 19, 2019
@efiop efiop added the bug Did we break something? label Nov 19, 2019
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Nov 19, 2019
@efiop efiop added p0-critical Critical issue. Needs to be fixed ASAP. triage Needs to be triaged labels Nov 19, 2019
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Nov 19, 2019
@efiop efiop added p1-important Important, aka current backlog of things to do and removed p0-critical Critical issue. Needs to be fixed ASAP. labels Nov 19, 2019
@efiop
Copy link
Contributor

efiop commented Nov 19, 2019

Hi @kaiogu !

This is definitely a bug on our side. Need to modify https://github.com/iterative/dvc/blob/0.69.0/dvc/command/remote.py#L51 to just logger.info() the existing value.

Thanks for the feedback!

@kaiogu
Copy link
Contributor Author

kaiogu commented Nov 19, 2019

Hi @efiop, thanks for developing DVC!

I could give it a try if you haven't already!

@efiop
Copy link
Contributor

efiop commented Nov 19, 2019

@kaiogu Sure, please go ahead! Let us know if you have any questions, we will be happy to help with it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something? p1-important Important, aka current backlog of things to do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants