Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote: base: walk_files might take a long time for big external directory #2911

Closed
efiop opened this issue Dec 6, 2019 · 4 comments
Closed
Labels
enhancement Enhances DVC p1-important Important, aka current backlog of things to do ui user interface / interaction

Comments

@efiop
Copy link
Contributor

efiop commented Dec 6, 2019

Better not forget to use progress bars when using walk_files. E.g. import-url s3://bucket/dir(same as run -d s3://bucket/dir and stuff like that)

@efiop efiop added the ui user interface / interaction label Dec 6, 2019
@efiop efiop added enhancement Enhances DVC p1-important Important, aka current backlog of things to do labels Dec 6, 2019
@Suor
Copy link
Contributor

Suor commented Dec 7, 2019

Or should we walk files while copying/importing them?

@efiop
Copy link
Contributor Author

efiop commented Dec 7, 2019

@Suor Not always. For example, _collect_dir is needed for checking if something has changed, so no copying/importing is happening. The recently introduced download logic could indeed do that, though.

@Suor
Copy link
Contributor

Suor commented Dec 7, 2019

When walking is the whole operation when showing pbar for that is a no-brainer. When collecting files is just a prerequisite to actual work then two consequential pbars is a questionable UI.

Another thing is that with walking we can't really show progress, since we don't know the number of files. We can, however, show a number of files found, this might be enough for a user if he or she knows an approximate number. And even if not at least some speed will be shown.

@efiop
Copy link
Contributor Author

efiop commented Oct 8, 2021

Closing as stale. This will be revisited during fs/ui/events development in the near future.

@efiop efiop closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC p1-important Important, aka current backlog of things to do ui user interface / interaction
Projects
None yet
Development

No branches or pull requests

2 participants