Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import: self-import should not check data-remote #2917

Closed
dmpetrov opened this issue Dec 7, 2019 · 2 comments
Closed

import: self-import should not check data-remote #2917

dmpetrov opened this issue Dec 7, 2019 · 2 comments
Labels
bug Did we break something? p2-medium Medium priority, should be done, but less important

Comments

@dmpetrov
Copy link
Member

dmpetrov commented Dec 7, 2019

$ dvc -V
0.75.0

# Self-import works just fine. It even does not use data-remote (I didn't push data).
$ dvc import . sources/file.csv --rev tag3

# But it fails when I checkout a revision with no data-remote specified.
# Data-remote was specified after tag1 revision.
$ dvc import . sources/file.csv --rev tag1
Importing 'sources/file.csv (.)' -> 'file.csv'
ERROR: failed to import 'sources/file.csv' from '.'. - No DVC remote is specified in target repository '.'.
@dmpetrov dmpetrov added bug Did we break something? p2-medium Medium priority, should be done, but less important labels Dec 7, 2019
@dmpetrov dmpetrov changed the title import: do not check remote of a self-import import: self-import should not check data-remote Dec 7, 2019
@efiop
Copy link
Contributor

efiop commented Dec 7, 2019

@dmpetrov Duplicate of #2599 , we have a WIP patch for it, will be solved soon.

@efiop efiop closed this as completed Dec 7, 2019
@efiop efiop reopened this Dec 7, 2019
@efiop efiop closed this as completed Dec 7, 2019
@efiop
Copy link
Contributor

efiop commented Dec 7, 2019

@dmpetrov Just to clarify: indeed, we shouldn't try to pull from remote when importing from the same repo that we are in, but that logic will automatically apply after #2599 , as we will simply set cache dir as a default remote if it doesn't exist, so we'll just check our cache against our cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something? p2-medium Medium priority, should be done, but less important
Projects
None yet
Development

No branches or pull requests

2 participants