Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce remote fixture #3210

Closed
pared opened this issue Jan 22, 2020 · 1 comment
Closed

Introduce remote fixture #3210

pared opened this issue Jan 22, 2020 · 1 comment
Labels
feature request Requesting a new feature good first issue p3-nice-to-have It should be done this or next sprint testing Related to the tests and the testing infrastructure

Comments

@pared
Copy link
Contributor

pared commented Jan 22, 2020

In many places in the tests we create local remote using tmp_path_factory (can be found by looking for RemoteConfig usages). And set it up "by hand". Introducing remote fixture should let us get rid of this boilerplate code. Few notes:

  • consider how to handle non-local remotes, and if we should create such fixture for each kind of remote
  • in erepo, we currently set remote to point to its cache, we should probably reconsider that and prepare separate remote for it when necessary
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Jan 22, 2020
@pared pared added the testing Related to the tests and the testing infrastructure label Jan 22, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Jan 22, 2020
@pared pared added feature request Requesting a new feature p3-nice-to-have It should be done this or next sprint good first issue labels Jan 22, 2020
@weekly-digest weekly-digest bot mentioned this issue Jan 26, 2020
Closed
@efiop
Copy link
Contributor

efiop commented Aug 26, 2020

We now have multiple remote fixtures as well as local_remote fixture. Closing.

@efiop efiop closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Requesting a new feature good first issue p3-nice-to-have It should be done this or next sprint testing Related to the tests and the testing infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@efiop @pared