Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff: if cache is missing we should at least notify that results are partial #3391

Closed
shcheklein opened this issue Feb 24, 2020 · 1 comment

Comments

@shcheklein
Copy link
Member

It's confusing to see just:

Modified:
    auc.metric
    data/features/
    model.pkl

files summary: 0 added, 0 deleted, 2 modified

when the actual output looks like this:

Modified:
    auc.metric
    data/features/
    data/features/test.pkl
    data/features/train.pkl
    model.pkl

files summary: 0 added, 0 deleted, 4 modified

Can we at least mention that result is partial (limited since cache is not available)?

@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Feb 24, 2020
@dmpetrov dmpetrov added bug Did we break something? p0-critical and removed triage Needs to be triaged bug Did we break something? p0-critical labels Feb 24, 2020
@dmpetrov
Copy link
Member

It shouldn't notify. It has to work properly without any cache. See reopened issue #2998

I increased the priority of #2998 because of this bug and mentioned that it is related to no cached data-dirs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants