Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repro: unexpected behavior #3419

Closed
shcheklein opened this issue Feb 27, 2020 · 3 comments
Closed

repro: unexpected behavior #3419

shcheklein opened this issue Feb 27, 2020 · 3 comments
Labels
bug Did we break something? p1-important Important, aka current backlog of things to do research ui user interface / interaction

Comments

@shcheklein
Copy link
Member

shcheklein commented Feb 27, 2020

(.env) [ivan@ivan ~/Projects/example-get-started]$ dvc repro evaluate.dvc
WARNING: Output 'data/features' of 'featurize.dvc' changed because it is 'modified'
WARNING: Stage 'featurize.dvc' changed.
Running command:
	python src/featurization.py data/prepared data/features
Output 'data/features' didn't change. Skipping saving.
WARNING: Output 'model.pkl' of 'train.dvc' changed because it is 'modified'
WARNING: Stage 'train.dvc' changed.
Running command:
	python src/train.py data/features model.pkl
Output 'model.pkl' didn't change. Skipping saving.

To track the changes with git, run:

	git add train.dvc featurize.dvc
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Feb 27, 2020
@shcheklein
Copy link
Member Author

Closing, mostly problem with a confusing repro output. Let's keep for the future.

@efiop efiop added the p1-important Important, aka current backlog of things to do label Feb 28, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Feb 28, 2020
@efiop efiop added bug Did we break something? triage Needs to be triaged labels Feb 28, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Feb 28, 2020
@efiop efiop added research ui user interface / interaction labels Mar 31, 2020
@dmpetrov
Copy link
Member

dmpetrov commented Apr 7, 2020

@shcheklein It would be really great if you could specify what part is unexpected.

Issues that I see:

  1. Double warning messages (modified output and then modified stage). The second message is not needed (it is already included in the 1st one).
  2. It should not be a warning - regular DVC behavior. Just an output (not INFO either).

Anything else?

@shcheklein
Copy link
Member Author

@dmpetrov it looks like I forgot I wrote that I'm closing this but forgot to actually close this. As far as I remember it looked to me that it was running something that it's not supposed to run - but turned out I was wrong. So, my intention was to close this and eventually create UI tickets when we get to repro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something? p1-important Important, aka current backlog of things to do research ui user interface / interaction
Projects
None yet
Development

No branches or pull requests

3 participants