Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkout: --relink show helpful message on completion #3484

Closed
skshetry opened this issue Mar 16, 2020 · 3 comments · Fixed by #7709
Closed

checkout: --relink show helpful message on completion #3484

skshetry opened this issue Mar 16, 2020 · 3 comments · Fixed by #7709
Labels
enhancement Enhances DVC good first issue p2-medium Medium priority, should be done, but less important ui user interface / interaction

Comments

@skshetry
Copy link
Member

skshetry commented Mar 16, 2020 •
edited
Loading

#3401 is merged. This introduced showing detailed checkout changes. If everything is relinked, but not changed (so, workspace is as it was before but everything was relinked), no output message is shown. We can at least show a message on dvc checkout --relink:

relinked successfully
@skshetry skshetry added the p2-medium Medium priority, should be done, but less important label Mar 16, 2020
@skshetry skshetry self-assigned this Mar 16, 2020
@skshetry skshetry added enhancement Enhances DVC ui user interface / interaction labels Mar 16, 2020
@skshetry skshetry removed their assignment Mar 16, 2020
@skshetry
Copy link
Member Author

I have intentionally left another enhancement:

At the moment, we don't have any way to differentiate between modified and relinked, as we just don't know if anything was modified on the workspace during checkout. I'd wait for users to ask for this (will not be easy to implement).

@mtszkw
Copy link

mtszkw commented Apr 22, 2021

Is this change still needed? This sounds like a perfect first issue to me @skshetry

@pared
Copy link
Contributor

pared commented Jun 15, 2021

@mtszkw Yest it is still needed, would you be interested in that? Sorry for late replay.

@ykasimov ykasimov mentioned this issue May 6, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhances DVC good first issue p2-medium Medium priority, should be done, but less important ui user interface / interaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

checkout: --relink show helpful message on completion ykasimov/dvc
3 participants
@pared @mtszkw @skshetry