-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exp show: include running experiment #5965
Comments
@shcheklein Please follow up to clarify anything that I missed on this. Also, can you clarify the motivation? Is it to give users with long-running experiments some confirmation that their experiment is running? I think this introduces some complications that raise new questions:
|
What should we even display for a running experiment? For workspace runs, we already have the Do we just want an equivalent table entry for whatever is in temp directory for It's not exactly clear what DVC should display, because outputs don't have to exist until a stage is completed. So for a long running stage command, nothing in the repo state may actually appear modified (from DVC's perspective) until the stage has completed. |
How about |
We should always see all the running/queued/executed experiments in the table. Can it be done but marking workspace with a special flag - probably, yes. It's a good point. But we still need to do this in the
yes, in a sense that I'd like to see that it's running now and being able to stop it. Also, can we show that it was cancelled? E.g. to launch it with a different set of params?
my initial take - it doesn't matter that much,
curious why do we call it branch? :)
good questions. I think it's related to Peter's point to some extent. We already have corresponding entries for pretty much all experiments, right? workspace, or queued entries ... we can utilize those, I guess? change their state somehow ... On the other hand, how do we show a running checkpoint? Ideally it should be "branched" out of the previous, not from the workspace? Not 100% sure here. |
Okay, this seems like the use case we are missing. There's no way to cancel an ongoing experiment now except to ctrl-c in the window where the experiment is running, and it's obvious it's running in that window. I can see how in vscode there might need to be something like a stop button in the table.
I called it a branch since the only difference between an experiment and a Git branch is the path to the ref ( Edit: Also, it seems this is getting towards functionality in #5615 |
@shcheklein If we start with adding any running experiments and checkpoints to the table, whether in the workspace or not, is that enough for now? Do we want to open a separate ticket for stopping an experiment? My opinions on how it should look:
|
yes! that would be a great start
yes, we can discuss and address it separately
For VS Code we care about the API ( |
@pmrowla Any questions or concerns? |
I'm not sure what you mean here? Whatever is cancelled or incomplete in the workspace is just the |
No, that's fine. I'm not sure how that will work in combination with showing the running experiment, but I can wait and see what it looks like. |
Show currently running experiment in the table. cc @shcheklein @pmrowla
The text was updated successfully, but these errors were encountered: