Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull: glob should not depend on what's in the workspace #7491

Closed
dberenbaum opened this issue Mar 22, 2022 · 2 comments
Closed

pull: glob should not depend on what's in the workspace #7491

dberenbaum opened this issue Mar 22, 2022 · 2 comments
Labels
A: cli Related to the CLI A: data-sync Related to dvc get/fetch/import/pull/push

Comments

@dberenbaum
Copy link
Collaborator

dvc pull --glob globs against the local workspace, which generally isn't very helpful when pulling:

dvc/dvc/repo/pull.py

Line 32 in 81eee05

expanded_targets = glob_targets(targets, glob=glob)

Ideally, dvc pull --glob should be globbing against the potential targets that could be pulled, including not only from .dvc files, but also pipeline outputs from dvc.lock.
@dberenbaum dberenbaum added A: cli Related to the CLI A: data-sync Related to dvc get/fetch/import/pull/push labels Mar 22, 2022
@dberenbaum
Copy link
Collaborator Author

Related: #7462

@sjawhar sjawhar mentioned this issue Mar 23, 2022
Closed
@dberenbaum
Copy link
Collaborator Author

Closing as a duplicate of #5864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: cli Related to the CLI A: data-sync Related to dvc get/fetch/import/pull/push
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dberenbaum