exp show: incorrect errors

[mattseddon]

Bug Report

Description

We are currently working on displaying experiment errors in the extension (iterative/vscode-dvc#1636). I have discovered that the msg/type fields in exp show errors shown at the file level can be incorrect. E.g

      "metrics": {
          "training_metrics.json": {
            "error": {
              "type": "YAMLFileCorruptedError",
              "msg": "unable to read: 'training_metrics.json', YAML file structure is corrupted"
            }
          }
        }

In the above example, training_metrics.json is not a YAML file.

Reproduce

1. open any project that has a JSON metrics file
2. corrupt the JSON in one of the metrics files.
3. run exp show --show-json

Expected

A more general FileCorruptedError would be good.

Environment information

Output of dvc doctor:

$ dvc doctor
DVC version: 2.11.0 (pip)
---------------------------------
Platform: Python 3.8.9 on macOS-12.2.1-arm64-arm-64bit
Supports:
        webhdfs (fsspec = 2022.5.0),
        http (aiohttp = 3.8.1, aiohttp-retry = 2.5.1),
        https (aiohttp = 3.8.1, aiohttp-retry = 2.5.1),
        s3 (s3fs = 2022.5.0, boto3 = 1.21.21)
Cache types: reflink, hardlink, symlink
Cache directory: apfs on /dev/disk3s1s1
Caches: local
Remotes: https
Workspace directory: apfs on /dev/disk3s1s1
Repo: dvc (subdir), git

Additional Information (if any):

The approach that we are currently running with in the extension is to highlight any experiments that have errors and show the actual error message in a tooltip on hover. For us, a more general message would definitely work.

[skshetry]

@mattseddon, can you check with the latest version please?

[mattseddon]

Resolved with 2.13.0 👍🏻.