Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caching per-revision exp show output #8748

Closed
skshetry opened this issue Dec 29, 2022 · 3 comments
Closed

caching per-revision exp show output #8748

skshetry opened this issue Dec 29, 2022 · 3 comments
Labels
A: experiments Related to dvc exp performance improvement over resource / time consuming tasks

Comments

@skshetry
Copy link
Member

This equally applies to metrics/params and plots. We can cache the computed results from every revisions which might be faster than trying to cache the whole index.

At first, we could try caching results without any error but in the long run, we should be able to distinguish between retryable errors (eg: FileNotFoundError in cache and remotes) vs unretryable errors (eg: dvc.yaml being broken and since it's tied to an immutable commit, it's never going to be fixed).

@skshetry skshetry added the performance improvement over resource / time consuming tasks label Dec 29, 2022
@dtrifiro dtrifiro added the A: experiments Related to dvc exp label Jan 3, 2023
@dberenbaum
Copy link
Collaborator

Should we break this issue into subtasks? I think the initial request of caching exp show output per revision is done, right?

@skshetry
Copy link
Member Author

skshetry commented Mar 3, 2023

I think we can close this as this was implemented in #9069.

@skshetry skshetry closed this as completed Mar 3, 2023
@dberenbaum
Copy link
Collaborator

Should we open other issues for these items?

This equally applies to metrics/params and plots.

At first, we could try caching results without any error but in the long run, we should be able to distinguish between retryable errors (eg: FileNotFoundError in cache and remotes) vs unretryable errors (eg: dvc.yaml being broken and since it's tied to an immutable commit, it's never going to be fixed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Related to dvc exp performance improvement over resource / time consuming tasks
Projects
None yet
Development

No branches or pull requests

3 participants