Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect live plots for experiments running in the queue #9369

Closed
dberenbaum opened this issue Apr 26, 2023 · 3 comments · Fixed by #9432
Closed

Collect live plots for experiments running in the queue #9369

dberenbaum opened this issue Apr 26, 2023 · 3 comments · Fixed by #9432
Assignees
Labels
A: plots Related to the plots A: task-queue Related to task queue. p1-important Important, aka current backlog of things to do product: VSCode Integration with VSCode extension

Comments

@dberenbaum
Copy link
Collaborator

Related: iterative/vscode-dvc#3676

cc @mattseddon

VS Code needs to show live updates to plots for experiments running in the queue. They should be able to use dvc plots diff or some other interface to pass the revisions they want to see and the order in which they want the spec to be merged (see this comment for the order in which VS Code merges) and get all the info they need to generate plots (datapoints and specs) without having to navigate to each queued temp dir to collect.

Nice to have:

  • Minimize the refactoring needed by VS Code (they currently use dvc plots diff exp1 exp2 ... -o .dvc/tmp/plots --split --json)
  • Enable dvc plots diff exp1 exp2 to similarly show the live results of those experiments running in the queue.
@dberenbaum dberenbaum added p1-important Important, aka current backlog of things to do product: VSCode Integration with VSCode extension A: plots Related to the plots A: task-queue Related to task queue. labels Apr 26, 2023
@dberenbaum
Copy link
Collaborator Author

The y-axis value for the plots is set to dvc_inferred_y_value if there are multiple y fields in the spec. That field depends on the spec, so I think if we want to consider the data/datapoints static, we would need to append this field when we merge revisions and determine the final spec.

@pmrowla pmrowla self-assigned this May 8, 2023
@pmrowla
Copy link
Contributor

pmrowla commented May 10, 2023

Just to clarify, is the only requirement here just that dvc plots diff exp-name ... includes the live/current datapoints if exp-name is a running experiment (and that all other existing dvc plots diff behavior regarding config merging and so on is to be left alone for now)?

@mattseddon @dberenbaum

@dberenbaum
Copy link
Collaborator Author

Correct, it looks like the current merging behavior in DVC and VS Code is good enough for now.

@pmrowla pmrowla added this to DVC May 16, 2023
@pmrowla pmrowla moved this to In Progress in DVC May 16, 2023
@pmrowla pmrowla moved this from In Progress to Review In Progress in DVC May 23, 2023
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in DVC May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: plots Related to the plots A: task-queue Related to task queue. p1-important Important, aka current backlog of things to do product: VSCode Integration with VSCode extension
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants