Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: verify before saving a modification #3193

Merged
merged 4 commits into from Jan 27, 2020
Merged

config: verify before saving a modification #3193

merged 4 commits into from Jan 27, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 19, 2020

Close #3192

efiop
efiop reviewed Jan 19, 2020
View reviewed changes
dvc/config.py Outdated Show resolved Hide resolved
efiop
efiop reviewed Jan 19, 2020
View reviewed changes
tests/func/test_remote.py Outdated Show resolved Hide resolved
@weekly-digest weekly-digest bot mentioned this pull request Jan 26, 2020
Closed
@efiop
Copy link
Contributor

efiop commented Jan 27, 2020

Thanks!

@efiop efiop merged commit 242b5b1 into iterative:master Jan 27, 2020
@ghost ghost deleted the fix-3192 branch January 27, 2020 17:33
@weekly-digest weekly-digest bot mentioned this pull request Feb 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config: check schema before applying modifications
1 participant
@efiop