experiments: more intelligent checkout behavior #4320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
reviewed
Aug 3, 2020
Comment on lines
+91
to
+97
| @contextmanager | ||
| def chdir(self): | ||
| cwd = os.getcwd() | ||
| os.chdir(self.exp_dvc.root_dir) | ||
| yield self.exp_dvc.root_dir | ||
| os.chdir(cwd) | ||
|
|
Contributor
There was a problem hiding this comment.
Don't see it being used anywhere
Contributor
Author
There was a problem hiding this comment.
It's used in experiments show, but got removed in the last PR by mistake.
Codecov Report
@@ Coverage Diff @@
## master #4320 +/- ##
==========================================
+ Coverage 91.20% 91.24% +0.03%
==========================================
Files 176 177 +1
Lines 12104 12182 +78
==========================================
+ Hits 11039 11115 +76
- Misses 1065 1067 +2
Continue to review full report at Codecov.
|
efiop
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Should fix #4289.
git reset --hardwhen doing checkout.dvc experiments checkout