-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plots: Improving the Grid #1254
Comments
@sroy3 thanks for the summary, and I like the idea with making them smaller/larger at certain break point to allocate all space. That will be a good improvement.
I think this is not even an alternative, but rather an expansion of the current idea and can be done as a next step on top of the media queries step. I would say, we should go this direction. I think it's fine for all of them to keep the same size first within a section even they are resized individually. As far as I understand it should be pretty straightforward, right? |
For the user resizing the plots, I have a few questions:
|
#1263 adds media queries to the plots grid and the comparison table.It improves a lot, but there are a few edge cases that need to be discussed and reworked.
|
Great stuff @sroy3 👍 |
Currently, the grid for the plots is built following these rules:
Drawbacks from These Current Rules
The bigger the size, the longer it will take for another plot to fit on the row when the plots have reached their max-width. For example, between the window sizes of 1040px and 2060px, the plots will appear pretty much static.
When the window is extra small, small plots might look very small. At a window size of 400px (the user might place multiple web views next to another), a plot would have a width of 106px.
Possible Solutions
Media Queries
By using media queries, we could further fine-tune how the plots react when resizing the window. That means that we could have the large plots be 100% of the screen until it reaches 1000px, then the plots could be 50%. With similar rules for the regular and small plots. We could then avoid the max-width and have plots always taking the maximum space, which would make things more fluid.
Let the User Do the Resizing
We could remove the plots sizes entirely and let the user resize the plots, either individually or all at once. Resizing them individually would allow total control to the user, but it could become a nightmare to manage when there are too many plots. Resizing that way could also be problematic when resizing the web view.
Allow Zooming
It could also be interesting for the user to see multiple plots at once (small or regular size) and then zoom on a certain plot to analyze. This could be done while applying the current rules and media queries.
Conclusion
I think that by adding media queries to what we currently have, we could make the current grid much more fluid, all the while continuing to use the current sizes.
The user resizing the plots would be a lot harder to manage for us and possibly the user.
Zooming on a certain plot could be a nice addition in the future.
The text was updated successfully, but these errors were encountered: