Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial column widths can be too small and cut off #1271

Closed
Tracked by #1054
rogermparent opened this issue Jan 29, 2022 · 1 comment
Closed
Tracked by #1054

Initial column widths can be too small and cut off #1271

rogermparent opened this issue Jan 29, 2022 · 1 comment
Labels
discussion priority-p2 Future feature, less priority for now product PR that affects product

Comments

@rogermparent
Copy link
Contributor

rogermparent commented Jan 29, 2022

Currently, the default column widths of the experiments table aren't aware of the lengths of the data and headers they contain, so they can be cut off by default. While truncation from #1142 makes this not look absolutely broken, some columns being truncated by default could be considered a bad look that we need to fix considering something like native HTML tables adapt to their contents' widths.

Screenshot of default widths with a slightly contrived example of columns that exemplify this:
screenshot of problem

Do we want to tackle this directly and make column widths adaptable by default, or are related solutions like #1142 and #1259 enough to make this a non-issue? If it's the latter, we may want to add title attributes to cells as well as headers (really, we may just want to do that anyway).

@rogermparent rogermparent added priority-p2 Future feature, less priority for now product PR that affects product discussion labels Jan 29, 2022
@mattseddon
Copy link
Contributor

Looks like the way that we are handling the width of the table/columns will be changed in #1565. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion priority-p2 Future feature, less priority for now product PR that affects product
Projects
None yet
Development

No branches or pull requests

2 participants