Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story: Inline edit of params from experiments webview #1537

Closed
mattseddon opened this issue Apr 8, 2022 · 2 comments
Closed

Story: Inline edit of params from experiments webview #1537

mattseddon opened this issue Apr 8, 2022 · 2 comments
Labels
A: experiments Area: experiments table webview and everything related enhancement New feature or request story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc

Comments

@mattseddon
Copy link
Member

mattseddon commented Apr 8, 2022

We want to be able to edit params values inline within the experiments webview.

🐉s:

  1. Parameters files can be TOML, JSON, YAML or Python files: https://dvc.org/doc/user-guide/glossary#parameter-dependency.
  2. Data type of each parameter is currently unknown.

Note: Studio team has already been through a couple of iterations of this. Look at what they have done.

From initial designs:

image

@mattseddon mattseddon added enhancement New feature or request story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc A: experiments Area: experiments table webview and everything related labels Apr 8, 2022
@mattseddon mattseddon changed the title Story: inline edit of params from experiments webview Story: Inline edit of params from experiments webview Apr 8, 2022
@mattseddon
Copy link
Member Author

One stepping stone to get us to this functionality would be to show the run/queue editor/title menu items whenever a params file is the active editor in the workspace:

image

@mattseddon
Copy link
Member Author

Closing placeholder and we have implemented a very basic solution. Will come back to it when we are ready to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related enhancement New feature or request story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc
Projects
None yet
Development

No branches or pull requests

1 participant