Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to toggle the Side Bar on/off #1836

Closed
maxagin opened this issue Jun 4, 2022 · 8 comments
Closed

Be able to toggle the Side Bar on/off #1836

maxagin opened this issue Jun 4, 2022 · 8 comments
Assignees
Labels
🎨 design Needs design input or is being actively worked on enhancement New feature or request

Comments

@maxagin
Copy link
Contributor

maxagin commented Jun 4, 2022

This is related to the #1562

Side Bar - Contains different views like the Explorer to assist you while working on your project.

Motivation

Please add this

TODO

Will be created after the motivation is completely clear

@maxagin
Copy link
Contributor Author

maxagin commented Jun 4, 2022

This is so we could start the conversation.

The idea is to have a control that will allow at the UI level to hide and show the Side Bar.

Open:

Screen Shot 2022-06-04 at 11 21 44 AM

Hidden:

Screen Shot 2022-06-04 at 11 32 39 AM

@maxagin maxagin self-assigned this Jun 4, 2022
@maxagin maxagin added enhancement New feature or request 🎨 design Needs design input or is being actively worked on status: 🎨 design-in-progress labels Jun 4, 2022
@shcheklein
Copy link
Member

VS Code itself takes care of that - Cmd B on Mac. On click on an active Icon. Or command palette, etc. We should not be duplicating this. Closing this, but Max please feel free to reopen or we can discuss it further if needed.

@maxagin
Copy link
Contributor Author

maxagin commented Jun 5, 2022

@shcheklein is this, not something we discussed during the last retrospective? “Be able to show the number of hidden fields when the sidebar is hidden” or something like this? I am actually aware of the shortcuts :) but thought you meant to have something extra.

@shcheklein
Copy link
Member

ah, I see. This approach doesn't solve the initial problem to my mind (or we would have to show that 7 number always, even when panel is visible). Also, the number itself is the most useful part, but we are introducing a bigger component just to show it, feel a bit too much. Also, it's hard to understand what does that number 7 mean to be honest - it's too far from the context.

looking into this though, made me thing that we can show this way the number of running experiments or number of queued experiments nearby the DVC icon, but it's a completely different story I think

@maxagin
Copy link
Contributor Author

maxagin commented Jun 5, 2022

So the motivation was: to be able to see the number of running experiments or number of queued experiments when the sidebar is hidden?

@shcheklein
Copy link
Member

No, the motivation was to see how many items in the table are not visible due to applied filters

@maxagin
Copy link
Contributor Author

maxagin commented Jun 7, 2022

The first thing that comes to mind is that the “how many items in the table are not visible due to applied filters” better be shown relative to the filters.
It means: we have filters in the webview or we have a sort of “filter” icon only with the information, that on click can toggle the sidebar and show all the filter options that were applied.

I have a feeling that the first option (filters in the webview) is more beneficial for the user :) WDYT?

@shcheklein
Copy link
Member

I think the most important part here are the "items" ... so, most likely, it would be good to see in the table itself that some items are filtered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 design Needs design input or is being actively worked on enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants