Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share to Studio: Include experiment_rev field. #3486

Closed
daavoo opened this issue Mar 17, 2023 · 1 comment · Fixed by #3499
Closed

Share to Studio: Include experiment_rev field. #3486

daavoo opened this issue Mar 17, 2023 · 1 comment · Fixed by #3499

Comments

@daavoo
Copy link
Contributor

daavoo commented Mar 17, 2023

The post request doesn't include the experiment_rev field:

const response = await sendPostRequest(studioAccessToken, {
baseline_sha: baselineSha,
client: 'vscode',
metrics: metrics || {},
name,
params: params || {},
repo_url: repoUrl,
type: 'done'

Which is used by Studio for rendering (and, in the future, for matching against parsed experiment revisions):

The 2 experiments only displaying the name are from VSCode Share to Studio action:

Captura de pantalla 2023-03-17 a las 13 23 46

The experiment_rev should be the full SHA

@mattseddon
Copy link
Member

Is this a new requirement or something that I missed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants