Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG: Initial implementation of stroke-dasharray attribute #97

Closed
wants to merge 1 commit into from

Conversation

Snipx
Copy link
Contributor

@Snipx Snipx commented Aug 12, 2022

For now only absolute values are supported. Percents are not supported

This got raised in https://stackoverflow.com/questions/73276129/itext7-doesnt-convert-the-svg-image-to-pdf-properly

For now only absolute values are supported. Percents are not supported
@Snipx
Copy link
Contributor Author

Snipx commented Aug 12, 2022

I tried my best but I know that it might still take more time to polish it to pass all the checks, sorry.

If you want to add some kind of a hook/trigger so that SonarQube checks are run for (at least some of the) PRs, I can take a look at fixing the SQ issues.

@Indhumathi-Syncron
Copy link

@Snipx Thanks for the implementation. This is giving expected results for dashed stroke array svg properties, When can we expect this to be delivered in itext7 library ?

@Indhumathi-Syncron
Copy link

Hello @Snipx ,
Could you please let us know when this stroke array implementation gets merged and released as maven ?

@vitali-pr
Copy link
Contributor

vitali-pr commented Dec 1, 2023

This pull request has been merged and the feature is now available in a snapshot version. Thank you, @Snipx .
Also stroke-dashoffset is supported.
4f2b6a0
And percents are also supported, see commit
e0b0a5d

@vitali-pr vitali-pr closed this Dec 1, 2023
@vitali-pr vitali-pr reopened this Dec 1, 2023
@vitali-pr vitali-pr requested review from vitali-pr and removed request for vitali-pr December 1, 2023 09:36
@vitali-pr vitali-pr closed this Dec 1, 2023
@vitali-pr vitali-pr mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants