Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: useful reth / alloy type conversions #82

Open
merklefruit opened this issue Sep 5, 2024 · 3 comments
Open

chore: useful reth / alloy type conversions #82

merklefruit opened this issue Sep 5, 2024 · 3 comments
Labels
A-providers Area: Providers crate A-rollup Area: rollup crate C-blocked A blocked issue C-enhancement New feature or request

Comments

@merklefruit
Copy link
Collaborator

merklefruit commented Sep 5, 2024

The following traits should be implemented in alloy to remove manual casting functions in op-rs:

  • impl From<reth::primitives::SealedBlock> for alloy::rpc::types::Block
  • impl From<reth::primitives::SealedHeader> for alloy::consensus::Header
  • impl From<reth::primitives::TransactionSigned> for Option<alloy::consensus::TxEnvelope> (TryFrom is fine too)
  • impl From<reth::rpc::types::Block> for alloy::rpc::types::Block<TxEnvelope>
@merklefruit merklefruit added C-enhancement New feature or request D-good-first-issue Desc: Good for newcomers A-providers Area: Providers crate A-rollup Area: rollup crate labels Sep 5, 2024
@GrapeBaBa
Copy link
Contributor

@merklefruit let me try

@GrapeBaBa
Copy link
Contributor

@merklefruit When I looked alloy, it did't depend on reth-primitives and i thought it should not, so i am confused does this issue make sense?

@merklefruit
Copy link
Collaborator Author

Yeah that's the issue. We can just wait to see if Reth is interested in using Alloy types for this and then it will be possible.
For now this is blocked - but would like to keep this open just to remember which type conversions we need eventually.

@merklefruit merklefruit added C-blocked A blocked issue and removed D-good-first-issue Desc: Good for newcomers labels Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-providers Area: Providers crate A-rollup Area: rollup crate C-blocked A blocked issue C-enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants