Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: itsgoingd/clockwork
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.3.1
Choose a base ref
...
head repository: itsgoingd/clockwork
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.3.2
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Dec 2, 2024

  1. LaravelNotificationsDataSource - fixed crash collecting anonymous not…

    …ifiables with database or broadcast channels.
    itsgoingd committed Dec 2, 2024
    Copy the full SHA
    243115c View commit details
  2. Copy the full SHA
    ffd1f16 View commit details
Showing with 9 additions and 1 deletion.
  1. +4 −0 CHANGELOG.md
  2. +1 −1 Clockwork/Clockwork.php
  3. +4 −0 Clockwork/DataSource/LaravelNotificationsDataSource.php
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
5.3.2

- fixed crash collecting Laravel on-demand notifications with database or broadcast channels (reported by michaelthedev, thanks!)

5.3.1

- fixed storing HTTP requests in SQL and Redis storage (reported by andrew-bannister, thanks!)
2 changes: 1 addition & 1 deletion Clockwork/Clockwork.php
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@
class Clockwork
{
// Clockwork library version
const VERSION = '5.3.1';
const VERSION = '5.3.2';

// Array of data sources, these objects collect metadata for the current application run
protected $dataSources = [];
4 changes: 4 additions & 0 deletions Clockwork/DataSource/LaravelNotificationsDataSource.php
Original file line number Diff line number Diff line change
@@ -276,6 +276,10 @@ protected function notificationAddressToString($address)
// Try to resolve a name for a notifiable, we try Eloquent email, name or default to a class name
protected function resolveNotifiableName($notifiable)
{
if ($notifiable instanceof \Illuminate\Notifications\AnonymousNotifiable) {
return 'anonymous';
}

$notifiableClass = is_object($notifiable) ? get_class($notifiable) : null;

if ($notifiable instanceof \Illuminate\Database\Eloquent\Model) {