Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #325

Open
joggienl opened this issue Feb 12, 2019 · 0 comments
Open

Refactor tests #325

joggienl opened this issue Feb 12, 2019 · 0 comments
Labels
enhancement

Comments

@joggienl
Copy link
Contributor

joggienl commented Feb 12, 2019 •
edited
Loading

Change the tests from using a Promise to async/await.
For inspiration check websocket.spec.js and audio-over-socket.spec.js.

In addition, current tests still fail sometimes and it is unclear why. It seems to be realted to promises.

It could be useful to get some ideas by this article: http://2ality.com/2016/04/unhandled-rejections.html

We could for instance add a beforeEach that handles the unhandledrejection event.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joggienl