Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause prop / control bug #46

Closed
fendorio opened this issue Aug 24, 2017 · 3 comments
Closed

Pause prop / control bug #46

fendorio opened this issue Aug 24, 2017 · 3 comments
Assignees

Comments

@fendorio
Copy link
Contributor

I see there is an issue similar to this headed "...Android", I think that this is not specific to Android though so I have created a new issue, feel free to ask to migrate this over to the existing one.

Basically, the play/pause button does not function correctly if you initialise the VideoPlayer component with paused being true.

If you initialise the component with paused={true} then the video is indefinitely paused, i.e. pressing play does not play the video - the UI updates (play icon is swapped with pause), but the video itself remains in a paused state.

In short, the pretty much renders the paused prop... not very useful?

I have only tested this on IOS so far, will try test on Android before the week is out.

Further detail and some code snippets below.

IOS 10.3.2
Device: Iphone 5
React native: 0.47.2 (and 0.45).

Code snippets below to demo what I have found:

Example 1
If we intialize the component with paused={true}, then the play button does not work, you cannot use the controls to play the video, i.e. it is stuck in a "paused" state.

<VideoPlayer
        paused={true} //Video starts as paused, pressing the play button does not start the video
/>

Example 2

Initializing the component with paused={false} does in-fact result in the play/pause button working. Although, this is problematic if you do not want the video to play automatically.

<VideoPlayer
        paused={false} //Video starts playing, pressing the play button does play / pause the video
/>
@Pianist038801
Copy link

Exactly same thing happened to me.
In my last project, I used react-native-video@1.2.0 and react-native-video-controls@1.3.0 and everything was working fine.
But in the latest version :(

@kylemilloy kylemilloy self-assigned this Aug 30, 2017
@kylemilloy
Copy link
Contributor

Likely an issue because I'm mass assigning props now...will take a look at this.

@kylemilloy
Copy link
Contributor

Resolved in v1.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants