Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for react native 0.49 #58

Closed
buruhsd opened this issue Dec 7, 2017 · 5 comments
Closed

for react native 0.49 #58

buruhsd opened this issue Dec 7, 2017 · 5 comments

Comments

@buruhsd
Copy link

buruhsd commented Dec 7, 2017

is this support for react native 0.49? i try this, but video cant load.

@kylemilloy
Copy link
Contributor

kylemilloy commented Dec 7, 2017 via email

@claire-kz
Copy link

I am also facing an issue and thinking it might be related to this.

I get the error react-native-video-controls@2.0.0" has incorrect peer dependency "react-native@0.47.2"

Here is the relevant portion of my package.json:

"dependencies": {
    "react": "^16.0.0",
    "react-native": "^0.50.3",
    "react-native-video": "^2.0.0",
    "react-native-video-controls": "^2.0.0",
  },

Looking at the package.json for react-native-video-controls in my node_modules/ folder, I see that indeed the peer dependency on react-native is for version 0.47.2.

I see you updated the dependency to be ">=0.46.0" in commit 80890f1, but running yarn install seems to pull the previous commit, where the version of this package was bumped but the dependency on react native was not (576f3ff). I get the package.json from this commit in my node_modules/.

It would appear that the latest version of this package is not hosted on npm. @kylemilloy can you verify that the version npm is hosting has the most recent commit?

In case it's useful, from my yarn.lock:

react-native-video-controls@^2.0.0:
  version "2.0.0"
  resolved "https://registry.yarnpkg.com/react-native-video-controls/-/react-native-video-controls-2.0.0.tgz#c4fc42b7f42471ff23fd3c4bb1e3d9055d305272"
  dependencies:
    lodash "^4.16.4"

Thank you!

@buruhsd
Copy link
Author

buruhsd commented Dec 12, 2017

okay, thank you

@kylemilloy
Copy link
Contributor

Good catch. 2.0.1 coming right up....

@claire-kz
Copy link

That fixed it! Thank you for the very quick response!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants