-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Thumbnails in DASH #3435
Comments
Well, this is probably going to be low priority to folks. |
I'm not really familiar with DASH either, especially given that it's a closed standard. Maybe try looking on the interwebs for existing DASH manifests with storyboards? |
After looking around, I figured that the standard gets developed mostly here https://github.com/Dash-Industry-Forum/DASH-IF-IOP with a reference implementation here https://github.com/Dash-Industry-Forum/dash.js I realized that this might be super low priority for most people since it's a niche needed feature, I took a stab at it. After lots of trial and error, I kinda made it work, by transforming this storyboard object
Into this (the first storyboard object in the json is discarded as the interval is 0)
Which I shove into the This made the thumbnails show up in the default viewer, which is a win The problem is that this setup does not account for the last page which might have a different size than the rest of the pages. Because of that, all the thumbnails look fine except the last page towards the end. But I can live with it. Implementation currently in iBicha/playlet#15 (more specifically) (warning, written badly in brightscript) |
Closing due to #3987 (comment) |
Is your feature request related to a problem? Please describe.
I'm currently building a Roku frontend for Invidious (Playlet)
Roku expects thumbnails, aka storyboards (for "trick play" or scrubbing through the progress bar) to be included in the DASH-IF manifest (DASH-standard thumbnail tiles)
So it would be cool to have an option where the storyboard included in the dash manifest, so that Roku can consume it properly
Describe the solution you'd like
/api/manifest/dash/id/:videoid
would return a DASH manifest that has the storyboard info included (like this example)Describe alternatives you've considered
I've tried to feed the storyboard manually into the system, and I did not succeed.
My options are to recreate the thumbnail data somehow (which is not trivial) or generate an extra
<AdaptationSet>
section for the thumbnails in the DASH manifest.The latter is the most doable solution, but it's still a bad solution because
Additional context
Is this feature is to be considered (I hope) maybe it could be an option like
/api/manifest/dash/id/:videoid?storyboard=true
so that the feature remains backward compatible with existing APIThe text was updated successfully, but these errors were encountered: