Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] RSS: Japanese video description encoding issues #4256

Closed
CatPlanet opened this issue Nov 12, 2023 · 18 comments
Closed

[Bug] RSS: Japanese video description encoding issues #4256

CatPlanet opened this issue Nov 12, 2023 · 18 comments
Labels
bug Something isn't working type:upstream The problem lies in one of the libraries, not in Invidious itself

Comments

@CatPlanet
Copy link

Describe the bug
Despite RSS channels' output being in UTF8 japanese video descriptions are total gibberish

Steps to Reproduce
Steps to reproduce the behavior:

  1. Go to https://yewtu.be/feed/channel/UCcp9uRaBwInxl_SZqGRksDA
  2. Cry
@CatPlanet CatPlanet added the bug Something isn't working label Nov 12, 2023
@CatPlanet CatPlanet changed the title [Bug] RSS: Japanese video desciption encoding issues [Bug] RSS: Japanese video description encoding issues Nov 12, 2023
@unixfox
Copy link
Member

unixfox commented Nov 12, 2023

Can you replicate the issue locally with a local instance of invidious?

@syeopite
Copy link
Member

Seems like a behavior specific to yewtu.be. I can't replicate this locally
replicate

@RadoslavL
Copy link
Contributor

Seems like a behavior specific to yewtu.be. I can't replicate this locally replicate

I can also replicate it in invidious.fdn.fr and inv.tux.pizza.

corrupted-characters

@absidue
Copy link
Contributor

absidue commented Nov 13, 2023

I wonder if there is something between Invidious and the user on those major instances that is messing up the encoding, maybe a reverse proxy or something that is incorrectly configured?

@unixfox
Copy link
Member

unixfox commented Nov 13, 2023

@syeopite did you try if you can replicate the issue in docker too?

@CatPlanet
Copy link
Author

Chinese channels are affected too https://yewtu.be/feed/channel/UCoC47do520os_4DBMEFGg4A
Taiwan https://yewtu.be/feed/channel/UC8ROUUjHzEQm-ndb69CX8Ww
Korean https://yewtu.be/feed/channel/UC5BMQOsAB8hKUyHu9KI6yig
Vietnam https://yewtu.be/feed/channel/UCOYdjTcOmle5oItjpEK0VpQ
Arabic noodles https://yewtu.be/feed/channel/UCfiwzLy-8yKzIbsmZTzxDgw

Titles, names are formatted correctly, same with actual video pages (not RSS ones). It's only the RSS description issue.

@syeopite
Copy link
Member

syeopite commented Nov 14, 2023

Invidious under docker is still able to render the RSS feeds correctly for me. But I am able to replicate this on public instances like onion.tube though.

iv.ggtyler.dev seems to be able to render the RSS feeds correctly

@absidue
Copy link
Contributor

absidue commented Nov 14, 2023

Does it work correctly on the test instance? afaik that is a default setup without any of the custom/non-standard stuff that most public instances do.

@RadoslavL
Copy link
Contributor

Does it work correctly on the test instance? afaik that is a default setup without any of the custom/non-standard stuff that most public instances do.

/feed/channel/UCoC47do520os_4DBMEFGg4A doesn't work properly on the test instance.
/feed/channel/UC8ROUUjHzEQm-ndb69CX8Ww doesn't work as well.

@absidue
Copy link
Contributor

absidue commented Nov 14, 2023

Maybe it's caused by the reverse proxy then?

@sefidel
Copy link

sefidel commented Feb 3, 2024

Can replicate this issue (NixOS 24.05), it's also happening on /api/v1/comments.

I've observed the same behaviour without reverse proxy (localhost also suffers from this problem).
Perhaps it's something with the build system?

Using the docker image works fine.

@sefidel
Copy link

sefidel commented Feb 3, 2024

This is most likely caused by an outdated version of Crystal.

See crystal-lang/crystal#13703 for more details. (Relevant Comment)

@SamantazFox SamantazFox added the type:upstream The problem lies in one of the libraries, not in Invidious itself label Feb 4, 2024
@kubo6472
Copy link

Possibly related, I found that the instance is okay, but the API is apparently the issue: lamarios/clipious#491

@sefidel
Copy link

sefidel commented Feb 27, 2024 via email

@iGerman00
Copy link

iGerman00 commented Jun 23, 2024

I'm able to reproduce this issue locally, behind Caddy as the reverse proxy, and through Tailscale - I'm pretty sure it's coming out of Invidious that way. I use the Docker imagequay.io/invidious/invidious:latest-arm64 as the way to run Invidious. It also happens to anything /api/. Is there any specific fix? What should the instance admin fix exactly?

@sefidel
Copy link

sefidel commented Jun 23, 2024

@iGerman00 Is there any specific fix? What should the instance admin fix exactly?

Compiling invidious with Crystal >=1.10.0 should solve the issue.
If you want to keep using that container image, I suggest opening a new issue/PR to bump the crystal version on the Dockerfile. (looks like the image uses 1.8.2)

@syeopite
Copy link
Member

The crystal version for the docker images will get bumped once #4654 is merged in the next batch.

@syeopite
Copy link
Member

#4654 has been merged and as such this should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working type:upstream The problem lies in one of the libraries, not in Invidious itself
Projects
None yet
Development

No branches or pull requests

9 participants