Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engines to package.json #1050

Closed
ivmartel opened this issue Dec 7, 2021 · 1 comment
Closed

Add engines to package.json #1050

ivmartel opened this issue Dec 7, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@ivmartel
Copy link
Owner

ivmartel commented Dec 7, 2021

The engines text specifies the compatible node versions (see doc). This will produce an error if run in strict mode, otherwise a warning.

@ivmartel ivmartel added the enhancement New feature or request label Dec 7, 2021
@ivmartel ivmartel modified the milestones: 0.31.2, 0.30.2 Dec 7, 2021
@ivmartel
Copy link
Owner Author

ivmartel commented Dec 7, 2021

node v12 gives an encoding error:

internal/encoding.js:398
throw new ERR_ENCODING_NOT_SUPPORTED(encoding);
^
RangeError [ERR_ENCODING_NOT_SUPPORTED]: The "iso-8859-1" encoding is not supported
at new TextDecoder (internal/encoding.js:398:15)
at new A.dicom.DataReader (/home/yves/dev/src/github/local/node/parse/node_modules/dwv/dist/dwv.min.js:3:24376)
at A.dicom.DicomParser.parse (/home/yves/dev/src/github/local/node/parse/node_modules/dwv/dist/dwv.min.js:3:45475)

This is because v12 does not come with full internationalisation by default (see v12 class_util_textdecoder). Full include started at v13 (see v13 changelog and v13 class_util_textdecoder)

So the minimum supported node will be v14 (the next LTS after v12).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant