Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why using digitalwrite(tx_pin,true) #29

Open
TeensyDucM opened this issue Nov 25, 2019 · 1 comment
Open

why using digitalwrite(tx_pin,true) #29

TeensyDucM opened this issue Nov 25, 2019 · 1 comment

Comments

@TeensyDucM
Copy link

hi,

thank's you for your project.

i contact you because in your code, you uses a lot about the kline functin by passing true or false.

If you remain, the kline function are described like that

kline(bool enabled){
digitalWrite(this->tx_pin, enabled);
}

or in the arduino specification, digitalWrite function wait about HIGH or LOW.

Can you explain me this ?

However, do you think this library are compatible with fiat implementation of the Kline protocol ( ISO14230 layout 4) i can provide you the specification about the headers.

thank's

@iwanders
Copy link
Owner

I'm not sure I 100% understand the question, but HIGH and LOW are just defines to true and false. In the function I use enabled as a variable. If enabled is true, it is equivalent to HIGH, if enabled is false it's equal to LOW. I hope this explains how the kline(bool enabled) function works.

Kline protocol ( ISO14230 layout 4)

I honestly don't know, I don't know what the difference is between layout 2 and layout 4. I expect modifications are necessary, but I don't know how many or how much work it would be. I don't have access to a car that does layout 4, so I would have no way to test changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants