-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider name change for OptionT<T>
#49
Comments
I think changing it to Why did we go with |
I wanted this library to be something that could be used in the browser as well as other contexts, but sadly I couldn't think of a good way around this at the time, so I just stuck a However, if you can think of a better solution to this problem, I'm all ears. |
So, summing up here, just to be clear about the result (heh) of making this change:
*(assuming we decide to build this one) Seem good to you guys? I'm slightly annoyed by the fact that |
LGTM. Think of them as containers and all of them are adjectives. Optional Container, Result Container, Validation Container. |
In total agreement of the name change. Thinking of them as containers definitely helps wrap my mind around them too. |
Awesome! I'll get to work on this asap. Thanks for the feedback here guys! |
I'd like to consider changing
OptionT<T>
to something less "bad" - for the lack of a better term - before we go 1.0. This is partly because it forcesResult<T, E>
to beResultT<T, E>
for consistency purposes, but also because I just don't likeOptionT<T>
at all.In addition, if we were to move forward with #40 (which I'd really like to do in some form or fashion, but maybe not until after 1.0). I'd hate to be forced into naming it
ValidationT<T, E>
just to matchOptionT<T>
andResultT<T, E>
.My only good suggestion at this point is
Optional<T>
(keepingSome<T>
andNone
), but we could also switch to the other naming convention which isMaybe<T>
withJust<T>
andNothing
as the two variants. I'm not as fond of theMaybe
naming convention, but if you guys think that's better than crow-barring our way through this problem just to use a variant of the word "Option", then I could be convinced to change it.Do you guys have any thoughts on this?
cc @brycehipp @ryanguill
The text was updated successfully, but these errors were encountered: