Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

尝试为MySQL添加SSL支持 #44

Merged
merged 2 commits into from
Apr 17, 2023
Merged

尝试为MySQL添加SSL支持 #44

merged 2 commits into from
Apr 17, 2023

Conversation

boris1993
Copy link
Contributor

因为TiDB Cloud强制使用SSL连接，故尝试为E5SubBot添加MySQL的SSL支持。
但是自测并没有通过SSL连接，貌似gorm不支持通过SSL连接MySQL？
总之先提交一版，然后可以的话我们一起看看怎么实现它。

@iyear
Copy link
Owner

iyear commented Mar 30, 2023

我不是太熟悉ssl连接数据库这方面的内容……你如果测试通过ping我一下我就合了发新版

@boris1993
Copy link
Contributor Author

好吧，虽然看起来就是连接字符串里面加上SSL相关的query string，但是gorm没用SSL去连，Google了也没啥有用的信息
先搁置了吧，等我有空了再研究看看

@boris1993
Copy link
Contributor Author

代码改好了，本机测试没发现啥问题

@iyear iyear merged commit bdfbcf0 into iyear:dev Apr 17, 2023
@iyear
Copy link
Owner

iyear commented Apr 17, 2023

感谢贡献:)

@boris1993
Copy link
Contributor Author

Docker没有构建新版本？

@iyear
Copy link
Owner

iyear commented Apr 17, 2023

有点忙，迟一点推tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boris1993 @iyear