Issue #115: provideIntegrity missing on Actor and Asset class #116
Conversation
| @@ -1144,6 +1145,8 @@ class Actor(Element): | |||
| checksDestinationRevocation = varBool(False, doc="""Correctly checks the revocation status | |||
| of credentials used to authenticate the destination""") | |||
| isAdmin = varBool(False) | |||
| # should not be settable, but accessible | |||
There was a problem hiding this comment.
Why it should not be settable? An actor can sign requests
There was a problem hiding this comment.
How about moving providesIntegrity to the base class?
There was a problem hiding this comment.
an actor signs a request via a process on their behalf, which should be looked at as a Process. I want to keep the Actor semantically separated (right now it is not) from the process it uses in order to allow us to use it for privacy threats later on.
There was a problem hiding this comment.
Using a plain bool doesn't solve this anyway. I think we should add not target.source.oneOf(Actor) or not target.source.providesIntegrity (and same for sink) in the thread condition.
There was a problem hiding this comment.
we probably need to implement a "unless_target()" filter or something for these cases.
you mean the plain bool doesn't solve the existing-but-not-settable part, or is there something beyond that I am not seeing here?
There was a problem hiding this comment.
TODO: revisit Element/Asset and how the attributes are inherited, clean up inheritance and come up with a cleaner, better method to treat these going forward.
No description provided.