Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Model ID column to be configurable. #33

Closed
jalcine opened this issue Nov 15, 2017 · 1 comment
Closed

Allow Model ID column to be configurable. #33

jalcine opened this issue Nov 15, 2017 · 1 comment

Comments

@jalcine
Copy link

jalcine commented Nov 15, 2017

I use UUIDs for my models with PostgreSQL (though the database layer shouldn't matter here). At this point in the insert bits, it looks like it's hardcoded to use id as the attribute.

I'm proposing to have a id_column configuration option that allows for specifying this.

Side-note: this looks like a prime spot for some refactoring re: how that Version struct is built!

@izelnakri
Copy link
Owner

We already have this feature, please check the documentation and you're welcome to issue a pull request for any refactors.

When I built this library it was very simple and in many ways it is still quite straightforward and stable in general(have many tests). In case if you are interested in refactoring and create a pull request I will make sure I will review it objectively, I don't hold any emotions against code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants