Skip to content

Commit 79a16d7

Browse files
author
j-griffith
committed
Update PVC DataSource to GA
Update KEP to note graduation from Beta to GA for sig-storage cloning feature in 1.18. Also add testing section to KEP. issue: kubernetes#989
1 parent a03c8df commit 79a16d7

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

keps/sig-storage/20181111-extend-datasource-field.md

+15-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ approvers:
1212
- "@thockin"
1313
editor: "@j-griffith"
1414
creation-date: 2018-11-11
15-
last-updated: 2019-07-17
15+
last-updated: 2020-01-27
1616
status: implementable
1717
see-also:
1818
replaces:
@@ -123,6 +123,18 @@ The primary risk of this feature is requesting a PVC DataSource when using a CSI
123123

124124
Due to the similarities between Clones and Snapshots, it is possible that some back ends may require queiscing in-use volumes before cloning. This proposal suggests that initially, if a csi plugin is unable to safely perform the requested clone operation, it's the csi plugins responsibility to reject the request. Going forward, when execution hooks are available (currently being proposed for consistent snapshots), that same mechanism should be made generally usable to apply to Clones as well.
125125

126+
## Test Plan
127+
128+
### Unit tests
129+
130+
Unit tests are already in place and include:
131+
* Unit tests ensure that spec that includes PVC DataSource is interpretted correctly
132+
* When a PVC DataSource is specified in the spec the resultant PVC object includes the cooresponding DataSource entry
133+
134+
### E2E tests
135+
136+
Require addition of E2E tests using the clone feature of the CSI host provisioner
137+
126138
## Graduation Criteria
127139
* API changes allowing specification of a PVC as a valid DataSource in a new PVC spec
128140
* Implementation of the PVC DataSource in the CSI external provisioner
@@ -134,6 +146,8 @@ Given that the only implementation changes in Kuberenetes is to enable the featu
134146
## Implementation History
135147

136148
1.15 - Alpha status
149+
1.16 - Beta status
150+
1.18 - GA Status
137151

138152
## Drawbacks [optional]
139153

0 commit comments

Comments
 (0)