You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@@ -123,6 +126,24 @@ The primary risk of this feature is requesting a PVC DataSource when using a CSI
123
126
124
127
Due to the similarities between Clones and Snapshots, it is possible that some back ends may require queiscing in-use volumes before cloning. This proposal suggests that initially, if a csi plugin is unable to safely perform the requested clone operation, it's the csi plugins responsibility to reject the request. Going forward, when execution hooks are available (currently being proposed for consistent snapshots), that same mechanism should be made generally usable to apply to Clones as well.
125
128
129
+
## Test Plan
130
+
131
+
### Unit tests
132
+
133
+
Unit tests are already in place and include:
134
+
* Unit tests ensure that spec that includes PVC DataSource is interpretted correctly
135
+
* When a PVC DataSource is specified in the spec the resultant PVC object includes the corresponding DataSource entry
136
+
137
+
Additional unit tests to be added:
138
+
* Attempt to clone while in deleting/failed/in-use state
139
+
140
+
### E2E tests
141
+
142
+
Require addition of E2E tests using the clone feature of the CSI host provisioner
143
+
* Clone a volume that is in raw block mode
144
+
* Same invalid state testing as in unit tests; deleting/failed/in-use
145
+
* Multiple simultaneous clone requests to the same volume
146
+
126
147
## Graduation Criteria
127
148
* API changes allowing specification of a PVC as a valid DataSource in a new PVC spec
128
149
* Implementation of the PVC DataSource in the CSI external provisioner
@@ -134,6 +155,8 @@ Given that the only implementation changes in Kuberenetes is to enable the featu
0 commit comments