Skip to content

Commit ef01145

Browse files
author
j-griffith
committed
Update PVC DataSource to GA
Update KEP to note graduation from Beta to GA for sig-storage cloning feature in 1.18. Also add testing section to KEP. issue: kubernetes#989
1 parent a03c8df commit ef01145

File tree

1 file changed

+24
-1
lines changed

1 file changed

+24
-1
lines changed

keps/sig-storage/20181111-extend-datasource-field.md

+24-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ approvers:
1212
- "@thockin"
1313
editor: "@j-griffith"
1414
creation-date: 2018-11-11
15-
last-updated: 2019-07-17
15+
last-updated: 2020-01-27
1616
status: implementable
1717
see-also:
1818
replaces:
@@ -36,6 +36,9 @@ superseded-by:
3636
- [Story 4](#story-4)
3737
- [Implementation Details/Notes/Constraints [optional]](#implementation-detailsnotesconstraints-optional)
3838
- [Risks and Mitigations](#risks-and-mitigations)
39+
- [Test Plan](#test-plan)
40+
- [Unit tests](#unit-tests)
41+
- [E2E tests](#e2e-tests)
3942
- [Graduation Criteria](#graduation-criteria)
4043
- [Implementation History](#implementation-history)
4144
- [Drawbacks [optional]](#drawbacks-optional)
@@ -123,6 +126,24 @@ The primary risk of this feature is requesting a PVC DataSource when using a CSI
123126

124127
Due to the similarities between Clones and Snapshots, it is possible that some back ends may require queiscing in-use volumes before cloning. This proposal suggests that initially, if a csi plugin is unable to safely perform the requested clone operation, it's the csi plugins responsibility to reject the request. Going forward, when execution hooks are available (currently being proposed for consistent snapshots), that same mechanism should be made generally usable to apply to Clones as well.
125128

129+
## Test Plan
130+
131+
### Unit tests
132+
133+
Unit tests are already in place and include:
134+
* Unit tests ensure that spec that includes PVC DataSource is interpretted correctly
135+
* When a PVC DataSource is specified in the spec the resultant PVC object includes the corresponding DataSource entry
136+
137+
Additional unit tests to be added:
138+
* Attempt to clone while in deleting/failed/in-use state
139+
140+
### E2E tests
141+
142+
Require addition of E2E tests using the clone feature of the CSI host provisioner
143+
* Clone a volume that is in raw block mode
144+
* Same invalid state testing as in unit tests; deleting/failed/in-use
145+
* Multiple simultaneous clone requests to the same volume
146+
126147
## Graduation Criteria
127148
* API changes allowing specification of a PVC as a valid DataSource in a new PVC spec
128149
* Implementation of the PVC DataSource in the CSI external provisioner
@@ -134,6 +155,8 @@ Given that the only implementation changes in Kuberenetes is to enable the featu
134155
## Implementation History
135156

136157
1.15 - Alpha status
158+
1.16 - Beta status
159+
1.18 - GA Status
137160

138161
## Drawbacks [optional]
139162

0 commit comments

Comments
 (0)