gotolinktarget.lua new tab parameter

[fredvej]

I suggest to add an optional parameter to gotolinktarget.lua to open a new tab for the target.

suggested new version attached
gotolinktarget.fv.lua.txt

I made put the cursor on target file work in Linux, I do not have a Windows PC to test on. I have not tested the recursive parameter.

diff below
`
11a12

newtab - will open the target directory in a new tab.
45c46
< local bfile, bfull, binactive = true, true, false

---

local bfile, bfull, binactive, bnewtab = true, true, false, false
86a88,89
if string.find(sparams, "newtab", 1, true) ~= nil then bnewtab = true end

90a94,96

if bnewtab == true then
DC.ExecuteCommand("cm_NewTab");
end
95,98c101,112
< if bfile == true then
< if binactive == true then
< DC.ExecuteCommand("cm_FocusSwap")
< DC.ExecuteCommand("cm_ChangeDir", stargetdir)

---

if binactive == true then
DC.ExecuteCommand("cm_FocusSwap")
if bnewtab == true then
DC.ExecuteCommand("cm_NewTab");
end
DC.ExecuteCommand("cm_ChangeDir", stargetdir)
else
if bnewtab == true then
DC.ExecuteCommand("cm_NewTab");
end
if SysUtils.ExtractFileDir(params[1]) == stargetdir then
DC.ExecuteCommand("cm_QuickFilter", "search=off")
100,108c114,115
< if SysUtils.ExtractFileDir(params[1]) == stargetdir then
< DC.ExecuteCommand("cm_QuickFilter", "search=off")
< else
< DC.ExecuteCommand("cm_ChangeDir", stargetdir)
< end
< end
< starget = SysUtils.ExtractFileName(starget)
< DC.ExecuteCommand("cm_QuickSearch", "search=on", "direction=first", "matchbeginning=off", "matchending=off", "casesensitive=" .. scase, "files=on", "directories=off", "text=" .. starget)
< DC.ExecuteCommand("cm_QuickSearch", "search=off")

---

DC.ExecuteCommand("cm_ChangeDir", stargetdir)

end
109a117,122
starget = SysUtils.ExtractFileName(starget)
-- must open and close tab to put cursor on target file
DC.ExecuteCommand("cm_NewTab");
DC.ExecuteCommand("cm_CloseTab");
DC.ExecuteCommand("cm_QuickSearch", "search=on", "direction=first", "matchbeginning=off", "matchending=off", "casesensitive=" .. scase, "files=on", "directories=off", "text=" .. starget)
DC.ExecuteCommand("cm_QuickSearch", "search=off")
`

[j2969719]

1.1+

--[[
Script (cross-platform) will check the symbolic link under the cursor and
- if the target object is a directory: will open the target directory;
- if the target object is a file: will open the parent directory and move the cursor to the target file.

Command: cm_ExecuteScript
Params:
  path-to-gotolinktarget.lua
  %"0%p0

Optional params:
  newtab    - will open the target directory in a new tab.
  inactive  - will open the target directory in the inactive panel and make it active.
  onlydir   - if the target object is a file, only the parent directory will be opened.
  recursive - if the link points to a link then it's resolved recursively until a valid
              file name that is not a link is found.

Button example:

DOUBLECMD#TOOLBAR#XMLDATA<?xml version="1.0" encoding="UTF-8"?>
<doublecmd>
  <Command>
    <ID>{4651FC8B-CC8A-4D8B-8741-DB29D812B7E3}</ID>
    <Icon>cm_symlink</Icon>
    <Hint>go to link target</Hint>
    <Command>cm_ExecuteScript</Command>
    <Param>$DC_CONFIG_PATH/scripts/lua/gotolinktarget.lua</Param>
    <Param>%"0%p0</Param>
    <Param>onlydir</Param>
  </Command>
</doublecmd>

]]

local DIALOG_TITLE = "Go to link target"

local MB_ICONERROR       = 0x0010
local MB_ICONWARNING     = 0x0030
local MB_ICONINFORMATION = 0x0040

local params = {...}

if #params == 0 then
  Dialogs.MessageBox("Required parameters are missing, please check the button settings.", DIALOG_TITLE, MB_ICONERROR)
  return
end

local faSymLink   = 0x00000400
local faDirectory = 0x00000010

function hasattr(fileattr, value)
  return (fileattr > 0 and math.floor(fileattr / value) % 2 ~= 0)
end

local filename = params[1]
local fileattr = SysUtils.FileGetAttr(filename)

if not hasattr(fileattr, faSymLink) then
  Dialogs.MessageBox('"' .. filename .. '" is not a symbolic link.', DIALOG_TITLE, MB_ICONERROR)
  return
end

local is_newtab    = false
local is_inactive  = false
local is_onlydir   = false
local is_recursive = false

if #params > 1 then
  local user_options = table.concat(params, ";", 2)
  is_newtab    = (user_options:find("newtab") ~= nil)
  is_inactive  = (user_options:find("inactive") ~= nil)
  is_onlydir   = (user_options:find("onlydir") ~= nil)
  is_recursive = (user_options:find("recursive") ~= nil)
end

local link_target = SysUtils.ReadSymbolicLink(filename, is_recursive)

if link_target == "" then
  Dialogs.MessageBox("This link is broken or the target storage is currently unavailable.", DIALOG_TITLE, MB_ICONINFORMATION)
  return
end

local is_absolute = false

if SysUtils.PathDelim == "/" then
  is_absolute = (link_target:sub(1, 1) == "/")
else
  is_absolute = (link_target:sub(2, 3) == ":\\")
end

if not is_absolute then
  link_target = SysUtils.GetAbsolutePath(link_target, SysUtils.ExtractFileDir(filename))
end

fileattr = SysUtils.FileGetAttr(link_target)

if fileattr == -1 then
  Dialogs.MessageBox('The target object "' ..  link_target .. '" is currently unavailable.', DIALOG_TITLE, MB_ICONINFORMATION)
  return
end

local is_link_to_dir = hasattr(fileattr, faDirectory)

if is_inactive then
  DC.ExecuteCommand("cm_FocusSwap")
end

if is_newtab then
  DC.ExecuteCommand("cm_NewTab")
end

if is_link_to_dir then
  DC.ExecuteCommand("cm_ChangeDir", link_target)
elseif is_onlydir then
  DC.ExecuteCommand("cm_ChangeDir", SysUtils.ExtractFileDir(link_target))
else
  DC.GoToFile(link_target, true)
end  

[Skif-off]

cm_NewTab/cm_CloseTab is not a pretty solution :)
Look at the first note, try without DC.ExecuteCommand("cm_Refresh") (before DC.ExecuteCommand("cm_QuickSearch", "search=on"-and-so-on).

[fredvej]

You are right @j2969719 , I tested my version in DC 1.1.28 with a link pointing to a file in a directory with a large number of files, and the cursor stayed at the very top of the list. However, without my work-around before calling cm_QuickSearch older DC versions will never place the cursor on the target file.

I think it is OK to ignore this, because no people using gotolinktarget.lua have complained before, so I may be the only user that use this script and want to place the cursor on the target file. My open&close usually works for me, so I suggest that you leave the script as it is now without my clumsy kludge.

The latest version of gotolinktarget.lua works perfectly in DC 1.1.30 placing the cursor on the target file. I look forward to my distro updates DC to 1.1.30.

Thank you for implementing the parameter newtab.

Best regards
Freddy

[fredvej]

Thank you @Skif-off , putting a delaying loop in the work-around works even in a directory with a large number of files.

This works for me in DC 1.1.28 :

if is_link_to_dir then
  DC.ExecuteCommand("cm_ChangeDir", link_target)
elseif is_onlydir then
  DC.ExecuteCommand("cm_ChangeDir", SysUtils.ExtractFileDir(link_target))
else
  if not pcall(DC.GoToFile, link_target, true) then
-- work-around for DC versions before 1.1.30
    DC.ExecuteCommand("cm_ChangeDir", SysUtils.ExtractFileDir(link_target))
-- delay to refresh directory before putting cursor on target file
    DC.ExecuteCommand("cm_Refresh")
    i = 10
    while i > 0 do
      SysUtils.Sleep(10)
      DC.ExecuteCommand("")
      i = i - 1
    end
    DC.ExecuteCommand("cm_QuickSearch", "search=on", "direction=first", "matchbeginning=off", "matchending=off", "casesensitive=" .. is_case, "files=on", "directories=off", "text=" .. SysUtils.ExtractFileName(link_target))
    DC.ExecuteCommand("cm_QuickSearch", "search=off")
  end
end

[j2969719]

you dont actually need the cm_Refresh itself, you just need everything except it. its just that with cm_Refresh, you might also run into a similar issue

[fredvej]

OK @j2969719 , I will remove the line with cm_Refresh to avoid problems.
Thank you