Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyEDFlib doesn't play nice at setup runtime #3

Closed
j9ac9k opened this issue Jul 25, 2018 · 2 comments
Closed

pyEDFlib doesn't play nice at setup runtime #3

j9ac9k opened this issue Jul 25, 2018 · 2 comments

Comments

@j9ac9k
Copy link
Owner

j9ac9k commented Jul 25, 2018

pyedflib requires numpy at setup_time

#!/usr/bin/env python
#-*- coding: utf-8 -*-

import os
import sys
import subprocess
from functools import partial

from setuptools import setup, Extension
from numpy import get_include as get_numpy_include
from distutils.sysconfig import get_python_inc

...

this can present a problem when bundling pyEDFlib as a dependency; as even if numpy is installed before pyEDFlib, it's not necessarily going to be available from the interpreter at runtime.

pygdal recently had a similar issue, but they appear to have resolved it, can reference to their setup.py file should be used

https://github.com/nextgis/pygdal/blob/master/setup.py

There is further discussion on this issue here: pypa/pipenv#2274

As pipenv (or pip for that matter) do let me specify install order or let me specify that one package is dependent on another one at setup time, the fix will likely have to be upstream at pyEDFlib.

@j9ac9k
Copy link
Owner Author

j9ac9k commented Jul 25, 2018

simpletraj appears to have resolved this issue in their setup.py:

https://github.com/arose/simpletraj/blob/master/setup.py

@j9ac9k
Copy link
Owner Author

j9ac9k commented Jul 29, 2018

I added cython as a dependency; and everything worked out. I assume that the pyedflib folks have not uploaded a wheel for python 3.7, so when I attempted to pip install, it needed to build it from the source distribution. It would fail doing so as cython was nowhere on my system (and that's a dependency to build pyedflib).

Will sleep on whether I want to add cython as a dependency for timeview.

@j9ac9k j9ac9k closed this as completed Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant