Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Google Limited Ads #208

Closed
sl-pierrevautherin opened this issue Feb 26, 2021 · 6 comments
Closed

Enable Google Limited Ads #208

sl-pierrevautherin opened this issue Feb 26, 2021 · 6 comments

Comments

@sl-pierrevautherin
Copy link
Contributor

sl-pierrevautherin commented Feb 26, 2021

use case: lots of companies are moving to Limited Ads for data-privacy and compliance reasons

about: Google Limited Ads gives publishers the ability to serve ads in a limited way, in the absence of consent for the use of cookies or other local identifiers.
Limited Ads only require the GPT library to be fetched from the pagead2 source:

Standard => https://securepubads.g.doubleclick.net/tag/js/gpt.js
Limited ads => https://pagead2.googlesyndication.com/tag/js/gpt.js

docs: https://developers.google.com/publisher-tag/guides/general-best-practices#load_from_an_official_source

suggested change: add an optionnal src prop to handle Limited Ads
The custom src provided by the user would replace the current "securepubads" value here => https://github.com/jaanauati/react-dfp/blob/master/js/utils.js#L6

I would be happy to open a PR if that's OK for you @jaanauati ?

@sl-pierrevautherin
Copy link
Contributor Author

I've got a PR ready
It includes unit tests and does not change the current load behavior ✔️

If you give me the rights on the repo, I can I submit it whenever you want @jaanauati

@jaanauati
Copy link
Owner

Hi @sl-pierrevautherin, that sounds good!, the development flow is pretty straitforward:

  1. you submit your pull request.
  2. code is reviewed.
  3. then the code is merged and new version is released to npm.

You should be able to submit a pull request (step #1), let me know if you are still facing any issues/errors.

Thanks.

@sl-pierrevautherin
Copy link
Contributor Author

Hi @jaanauati ,

Thanks for your kind reply!
It seems I cannot push my PR at the moment

ERROR: Permission to jaanauati/react-dfp.git denied to sl-pierrevautherin. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists.

Could you grant me access rights to the repo please ?
Thanks a lot!

@sl-pierrevautherin
Copy link
Contributor Author

OK done => #209

@jaanauati
Copy link
Owner

v 0.20.0 has been pushed to npm. @sl-pierrevautherin please give a try and let me know if u find any issues.

Thank you for your work on this.

@sl-pierrevautherin
Copy link
Contributor Author

sl-pierrevautherin commented Mar 5, 2021

Thanks @jaanauati !

The last version on NPM is 0.19.0.
https://www.npmjs.com/package/react-dfp
I suppose the npm-publish is still pending,

I'll check again in a few minutes

Edit : it works fine! (12th March 2021)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants