You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When adding tests of #2529, found there are some logic having conflicts, it may because of the merit list is developing.
If the merit list is finished, it may worth to confirm following logic conflicts still remain or not.
In src/views/Exercise/Tasks/Task/Finalised/meritListHelper.js
totalPassed(task, scoreType, scores)
Confirm if this change work. This change is for the function can accept the return values of scores(task, scoreType, exerciseDiversity) for scores parameter and pass the tests.
related tests
[totalPass] should calculate total passed correctly without overrides
[totalPass] should calculate total passed correctly with overrides
[scores] should correctly calculates cumulative diversity data
Background
When adding tests of #2529, found there are some logic having conflicts, it may because of the merit list is developing.
If the merit list is finished, it may worth to confirm following logic conflicts still remain or not.
In src/views/Exercise/Tasks/Task/Finalised/meritListHelper.js
scores(task, scoreType, exerciseDiversity)
for scores parameter and pass the tests.type
parameter comparing with different constants, the inner block may never be excuted.In src/helpers/taskHelper.js
function markingScheme2Columns(markingScheme, editable = false)
logicThe text was updated successfully, but these errors were encountered: